operator: Improve messages for errors in storage secret #11824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
kverrorslibrary we currently use to emit errors found in the storage secret is not well suited for this task, because theError()output does not contain the structured metadata which makes many error messages ambiguous. As we use these error messages in the status of the LokiStack this is not helpful for the user.Which issue(s) this PR fixes:
Special notes for your reviewer:
This has been extracted from #11802. That PR needs to be updated again when this is merged.
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdated