fix(bloomstore): Keep synchronous state between cache and fs on entry eviction #11880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/fetch-block-querier
branch
2 times, most recently
from
a532a58
to
e83e092
Compare
chaudum
force-pushed
the
chaudum/make-evict-callback-synchronous
branch
from
7122524
to
0a05c39
Compare
chaudum
force-pushed
the
chaudum/make-evict-callback-synchronous
branch
from
0a05c39
to
fcaddea
Compare
chaudum
force-pushed
the
chaudum/make-evict-callback-synchronous
branch
2 times, most recently
from
9abfe45
to
66e2e9f
Compare
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/make-evict-callback-synchronous
branch
2 times, most recently
from
53de5c3
to
114e6af
Compare
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/make-evict-callback-synchronous
branch
from
114e6af
to
be54b1e
Compare
chaudum
changed the title
chaudum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
removeBlockDirectoryis called by the cache when an item is evicted.The cache entry is passed to this function. The function needs to evict/invalidate the entry synchronously, otherwise we could get a cache race condition where the item is already evicted from the cache, but the underlying directory isn't.
However, instead of removing the directory immediately, the function only renames it, so existing readers can still access the files. The actual cleanup of the directory happens asynchronously once the readers count is zero.