Tail queue #11930
Merged
Tail queue #11930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvacorts
force-pushed
the
salvacorts/debug-tail-queue
branch
from
67f851e
to
d8eccd3
Compare
salvacorts
force-pushed
the
salvacorts/debug-tail-queue
branch
from
d8eccd3
to
9e39142
Compare
na--
reviewed
Feb 16, 2024
| @@ -288,30 +288,28 @@ func (s *stream) recordAndSendToTailers(record *wal.Record, entries []logproto.E | |||
| hasTailers := len(s.tailers) != 0 | |||
| s.tailerMtx.RUnlock() | |||
| if hasTailers { | |||
| go func() { | |||
There was a problem hiding this comment.
Hmm I don't understand the surrounding code, but from the recordAndSendToTailers() name and from the previous usage of a goroutine here, I assume this part should be as non-blocking as possible? If so, does it make sense to keep the goroutine here? We'd still handle the actual sending over a queue, but this part won't be blocking either.
There was a problem hiding this comment.
We are removing the goroutine and sending the stream to the queue. Since the queue is a buffered channel, it's a non-blocking opt (if chan is full, the stream is dropped)
na--
reviewed
Feb 16, 2024
slim-bean
reviewed
Feb 19, 2024
pkg/ingester/tailer.go
Outdated
| for { | ||
| select { | ||
| case <-t.conn.Context().Done(): | ||
| t.close() |
There was a problem hiding this comment.
I think maybe t.close() should be in a defer block so that anywhere we return from this function it would be called?
slim-bean
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.