chore(blooms): Improve how block directory is extracted #12030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
salvacorts
approved these changes
Feb 22, 2024
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
This PR contains two changes: 1) Extracting the block without an intermediate temp file. The commit is cherry-picked from grafana#12021, but that PR got merged into the wrong branch 馃檲 2) Strip `.tar.gz` suffix from block file when extracting it into a directory. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
This PR contains two changes: 1) Extracting the block without an intermediate temp file. The commit is cherry-picked from grafana#12021, but that PR got merged into the wrong branch 馃檲 2) Strip `.tar.gz` suffix from block file when extracting it into a directory. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> merge Signed-off-by: hfuss <hayden.fuss@kaleido.io>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
This PR contains two changes: 1) Extracting the block without an intermediate temp file. The commit is cherry-picked from grafana#12021, but that PR got merged into the wrong branch 馃檲 2) Strip `.tar.gz` suffix from block file when extracting it into a directory. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains two changes:
The commit is cherry-picked from fix: Extract block directory directly from gzipped tar reader聽#12021, but that PR got merged into the wrong branch 馃檲
.tar.gzsuffix from block file when extracting it into a directory.