ci: CVE scanning and bump release pipeline #12031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
changed the title
paul1r
approved these changes
Feb 28, 2024
edsoncelio
pushed a commit
to edsoncelio/loki
that referenced
this pull request
Mar 22, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
snyk containercommand does not like the way we build images, complaining of an invalid OCI format. Since we have the snyk action, lets just use that on release branches as well, and focus theMakefiletarget to thetrivyandsnykcommands that work in everyone's local env.This also removes the snyk and trivy PR comment tools as they were broken. There were edge case to the JSON parsing that aren't really worth investing in now. We have other ways of being notified about CVEs.
Finally this bumps the release pipeline to the most current version, which brings back integrations tests (but as a separate/parallel step)