chore(blooms): Various fixes in blooms read path #12036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
salvacorts
approved these changes
Feb 22, 2024
pkg/bloomgateway/querier.go
Outdated
| func NewQuerier(c Client, r prometheus.Registerer, logger log.Logger) *BloomQuerier { | ||
| return &BloomQuerier{ | ||
| c: c, | ||
| metrics: newQuerierMetrics(r, constants.Loki, "bloom_gateway_querier"), |
There was a problem hiding this comment.
Add string as constant?
There was a problem hiding this comment.
Can do, but it's really only used here.
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
* Wire up bloom querier metrics to fix nil pointer panic * Use `bloomutils.TokenRangesForInstance` instead of `subRing.GetTokenRangesForInstance` to avoid `zone not set` error Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
* Wire up bloom querier metrics to fix nil pointer panic * Use `bloomutils.TokenRangesForInstance` instead of `subRing.GetTokenRangesForInstance` to avoid `zone not set` error Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
* Wire up bloom querier metrics to fix nil pointer panic * Use `bloomutils.TokenRangesForInstance` instead of `subRing.GetTokenRangesForInstance` to avoid `zone not set` error Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
bloomutils.TokenRangesForInstanceinstead ofsubRing.GetTokenRangesForInstanceto avoidzone not seterror