Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): fix reference leak and resulting race condition in BloomPageDecoder #12050

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Feb 23, 2024

Removes the Drop() function for now and adjusts some pool usage according to the following:

  • Minor refactoring
  • Reference leak in BloomPageDecoder
  • Race condition due to the above

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
…geDecoder

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner February 23, 2024 18:33
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 7c8992f into grafana:main Feb 23, 2024
12 of 13 checks passed
@owen-d owen-d mentioned this pull request Mar 21, 2024
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants