Fix docker latest and master tags #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r images for single arch images allow passing additional tags into the image-tag step and into .tags file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
I couldn't just add the
latestandmastertags directly to the.tagsfile for multi-arch images because it resulted in drone/docker creating and pushing alatestandmasterfor each architecture which then interferes with the manifest.So instead I just added the
latestandmastertags to the template for the manifest generation.FYI if anyone is curious how this drone manifest plugin actually works, it's just a thin wrapper around: https://github.com/estesp/manifest-tool, which is what the template file definition is based on.
For the fluent-bit image which is only built for amd64 and doesn't push a manifest file, I extended the jsonnet function which creates the
image-tagstep to accept an optional list of comma separated tags to put into the .tags file which is then used by the drone docker plugin to push images with those tags.This allows pushing a
latestandmastertag for the fluent-bit image