Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix typo of docker driver configuration option #12131

Merged
merged 5 commits into from Mar 15, 2024
Merged

docs: Fix typo of docker driver configuration option #12131

merged 5 commits into from Mar 15, 2024

Conversation

ltoenning
Copy link
Contributor

What this PR does / why we need it:
There was a typo in the documentation for a configuration option (using underscore instead of equal sign).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ltoenning ltoenning requested a review from a team as a code owner March 5, 2024 20:40
@CLAassistant
Copy link

CLAassistant commented Mar 5, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 5, 2024
JStickler
JStickler approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@MichelHollands MichelHollands merged commit e65e75a into grafana:main Mar 15, 2024
12 checks passed
grafanabot pushed a commit that referenced this pull request Mar 15, 2024
@ltoenning @grafana-delivery-bot
docs: Fix typo of docker driver configuration option (#12131)
0fbae67 
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit e65e75a)
@grafanabot grafanabot mentioned this pull request Mar 15, 2024
Merged
8 tasks
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@ltoenning @MichelHollands
@JStickler @rhnasc
docs: Fix typo of docker driver configuration option (grafana#12131)
2980501 
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
backport release-2.9.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ltoenning @CLAassistant @grafanabot @JStickler @MichelHollands