Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(operator): Fix managed auth features annotation for community-openshift bundle #12157

Merged
merged 2 commits into from Mar 11, 2024
Merged

fix(operator): Fix managed auth features annotation for community-openshift bundle #12157

merged 2 commits into from Mar 11, 2024

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Mar 7, 2024 •
edited

What this PR does / why we need it:
Sets features.operators.openshift.io/token-auth-azure: "true" for the community-openshift bundle.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Mar 7, 2024
@periklis periklis requested review from xperimental and a team as code owners March 7, 2024 13:09
@periklis periklis force-pushed the fix-operator-feature-annotations branch from 4728d00 to 4d83d97 Compare March 11, 2024 16:03
@periklis periklis changed the title fix(operator): Enable all managed auth features annotations fix(operator): Fix managed auth features annotation for community-openshift bundle Mar 11, 2024
@periklis periklis merged commit c1f1776 into grafana:main Mar 11, 2024
17 of 18 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@periklis @rhnasc
fix(operator): Fix managed auth features annotation for community-ope…
373f36b 
…nshift bundle (grafana#12157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental xperimental approved these changes

Assignees

@periklis periklis

Labels
sig/operator size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@periklis @xperimental