Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blooms): bloom-gw chunk merging improvements #12162

Merged
merged 8 commits into from
Mar 8, 2024
Merged

fix(blooms): bloom-gw chunk merging improvements #12162

merged 8 commits into from
Mar 8, 2024

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Mar 8, 2024

  • histogram metrics for requested vs filtered chunks (aggregate, not per day task)
  • benchmarking
  • improved filterChunkRefs implementation for the bloomcompactor. Both fixes a few mentioned bugs and improves performance.
  • testware
  • unrelated: ensures we sort chunks prior to committing series to bloom block during construction. This was done elsewhere, but doing it closer to the block itself feels safer.

@owen-d
ensures chunks are sorted prior to adding to bloom block
9f0a28d 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
introduces new bloom-gw merging code, rethinks some metrics
43fc5ff 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
heapsort day responses
eb9227a 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
optimized shortcuts for orderedResponsesByFP
8de8c54 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
middle duplicates test across 2 days
563b205 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner March 8, 2024 02:33
@owen-d owen-d changed the title fix(blooms): fix(blooms): bloom-gw chunk merging improvements Mar 8, 2024
@owen-d
correctly returns filtered chunk refs
4063e0e 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
removes gateway.{processResponses,removeNotMatchingChunks}
0676966 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d mentioned this pull request Mar 8, 2024
Closed
8 tasks
@owen-d
ptr to slice in pool lint in benchmark
891e46e 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d merged commit f4b2c5d into grafana:main Mar 8, 2024
11 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@owen-d @rhnasc
fix(blooms): bloom-gw chunk merging improvements (grafana#12162)
ee2206b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owen-d @chaudum