Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lokitool #12166

Merged
merged 11 commits into from
Apr 18, 2024
Merged

feat: add lokitool #12166

merged 11 commits into from
Apr 18, 2024

Conversation

MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Mar 8, 2024

What this PR does / why we need it:

  • Copy across the rules part from cortex-tool and add it to a new lokitool binary.
  • Add a makefile target: make lokitool
  • Fixed the linter issues of the copied code
  • Removed the backend parameter
  • Renamed things from Cortex to Loki
  • Removed Cortex specific tests

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands requested a review from a team as a code owner March 8, 2024 13:57
@MichelHollands MichelHollands changed the title Add lokitool feat: Add lokitool Mar 8, 2024
@MichelHollands MichelHollands changed the title feat: Add lokitool feat: add lokitool Mar 8, 2024
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] Just looking at the markdown (.md) files, it doesn't look like the references to "cortex" in the user docs have been updated. Was that an oversight, or were you planning to update the docs in a separate PR?

@MichelHollands
Copy link
Contributor Author

[Docs team] Just looking at the markdown (.md) files, it doesn't look like the references to "cortex" in the user docs have been updated. Was that an oversight, or were you planning to update the docs in a separate PR?

This was an oversight. This PR is already so big I stopped working on it for now. More PRs will follow to get this into shape. One fixing references to cortex will be one of them. Thanks for letting me know.

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
.gitignore Show resolved Hide resolved
cmd/lokitool/main.go Outdated Show resolved Hide resolved
pkg/tool/client/rules_test.go Outdated Show resolved Hide resolved
pkg/tool/commands/rules.go Outdated Show resolved Hide resolved
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands merged commit 7b7d3d4 into main Apr 18, 2024
10 checks passed
@MichelHollands MichelHollands deleted the add_lokitool branch April 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants