Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes compactor shutdown log #12195

Merged

Conversation

cyriltovena
Copy link
Contributor

Found this while debugging something, if an error is there it won't show up because you need key and values.

@cyriltovena cyriltovena requested a review from a team as a code owner March 13, 2024 08:27
@cyriltovena cyriltovena changed the title Fixes compactor shutdown log fix: Fixes compactor shutdown log Mar 13, 2024
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 19f5f3f into grafana:main Mar 13, 2024
13 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants