perf(bloom-gw): Dequeue single task in bloom gateway worker #12209
+22
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
changed the title
chaudum
force-pushed
the
chaudum/dequeue-single
branch
from
e7b7aca
to
89cfd1c
Compare
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/dequeue-single
branch
from
89cfd1c
to
735c5d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies task execution. A single slow task that requires a lot of bloom checks may slow down all other tasks executed within the same multiplexed execution.
While the idea of multiplexing requests/tasks was to reduce file i/o as well as memory consumption, it turned out that the downside of slowing down individual requests does not benefits.
More observations and metrics are needed to verify this assumption, but initial tests showed a significant decrease in p99 latency for bloom gateway requests.