Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blooms): Dedupe download queue items to reduce queue size #12222

Merged

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

This PR attempts to avoid enqueueing multiple times the same download request for the same block and reduce the queue size.

The goal is to reduce the size of the queue. I've also changed the behaviour where if the queue is full we just drop the request and we should have a metrics because it might means we need to scale up bloom gateway.

We should test this in dev and see if it has negative impact.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@cyriltovena cyriltovena marked this pull request as ready for review March 18, 2024 18:36
@cyriltovena cyriltovena requested a review from a team as a code owner March 18, 2024 18:36
@cyriltovena cyriltovena enabled auto-merge (squash) March 18, 2024 18:51
@cyriltovena cyriltovena merged commit cdb934c into grafana:main Mar 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants