Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(image-tags): exclude helm release tags #12240

Merged
merged 1 commit into from Mar 18, 2024
Merged

chore(image-tags): exclude helm release tags #12240

merged 1 commit into from Mar 18, 2024

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:
Do not use helm release tags for creating image-tag for loki, promtail and other images that are published with merged commits

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner March 18, 2024 06:48
@ashwanthgoli ashwanthgoli merged commit 98e604c into main Mar 18, 2024
13 checks passed
@ashwanthgoli ashwanthgoli deleted the image-tag-exclude-helm branch March 18, 2024 08:35
edsoncelio pushed a commit to edsoncelio/loki that referenced this pull request Mar 22, 2024
@ashwanthgoli @edsoncelio
chore(image-tags): exclude helm release tags (grafana#12240)
e8dca07
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@ashwanthgoli @rhnasc
chore(image-tags): exclude helm release tags (grafana#12240)
4d50237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashwanthgoli @chaudum