Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove lost character in ciliumnetworkpolicy.yaml #12263

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix: Remove lost character in ciliumnetworkpolicy.yaml #12263

merged 1 commit into from Mar 19, 2024

Conversation

Pionerd
Copy link
Contributor

@Pionerd Pionerd commented Mar 19, 2024 •
edited

What this PR does / why we need it: Random character breaks Loki helm chart when enabling CiliumNetworkPolicies

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Pionerd Pionerd requested a review from a team as a code owner March 19, 2024 17:23
@Pionerd Pionerd changed the title Remove lost character in ciliumnetworkpolicy.yaml fix: Remove lost character in ciliumnetworkpolicy.yaml Mar 19, 2024
JStickler
JStickler approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Looks like a typo to me! Thanks for fixing this.

@JStickler JStickler merged commit 2e7dbe6 into grafana:main Mar 19, 2024
15 checks passed
edsoncelio pushed a commit to edsoncelio/loki that referenced this pull request Mar 22, 2024
@Pionerd @edsoncelio
fix: Remove lost character in ciliumnetworkpolicy.yaml (grafana#12263)
869ff5d
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@Pionerd @rhnasc
fix: Remove lost character in ciliumnetworkpolicy.yaml (grafana#12263)
823bcdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
area/helm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pionerd @JStickler