Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: track main of loki-release on main branch #12264

Merged
merged 5 commits into from Mar 19, 2024

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Mar 19, 2024

What this PR does / why we need it:
This PR makes main track the main branch of loki-release, which updates the release pipelines and brings back the check-format task. This won't have an affect on old release branches (ie. release-2.9.x), but will make future weeklies run their minor release pipeline (which we're not using until post 3.0 anyway) off main of grafana/loki-release.

Update: by updating the release code, we're bringing back the integration tests. This PR also includes a fix for the failing OTLP tests.

* this brings back the `check-format` task
@trevorwhitney trevorwhitney requested a review from a team as a code owner March 19, 2024 18:03
@MasslessParticle
Copy link
Contributor

Can we include a make format make task in this so it's easy to fix once the check is back?

@trevorwhitney
Copy link
Collaborator Author

@MasslessParticle there already is a format task. This is just adding the invocation of check-format back to the pipeline, doesn't change the tasks in the Makefile at all

@MasslessParticle
Copy link
Contributor

🤦‍♂️ Nice, 👍

@trevorwhitney trevorwhitney merged commit 4cf47da into main Mar 19, 2024
12 checks passed
@trevorwhitney trevorwhitney deleted the bring-back-check-format branch March 19, 2024 21:33
edsoncelio pushed a commit to edsoncelio/loki that referenced this pull request Mar 22, 2024
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants