Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker install doc #1227

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Add docker install doc #1227

merged 2 commits into from
Jan 16, 2020

Conversation

daixiang0
Copy link
Contributor

Fix #1210
Signed-off-by: Xiang Dai 764524258@qq.com

@daixiang0
Copy link
Contributor Author

@slim-bean @rfratto @cyriltovena @sh0rez mind hava a look?

@marthydavid
Copy link

+1

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jan 11, 2020
@daixiang0
Copy link
Contributor Author

@slim-bean @rfratto @cyriltovena @sh0rez mind hava a look?

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jan 13, 2020
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
@sh0rez
Copy link
Member

sh0rez commented Jan 13, 2020

Personally, I would drop the docker bit ... running Loki using docker cannot be recommended, as it is not a very persistent solution ... the docker command only really works well for short lived containers.

After all, not even docker-compose can be considered a production ready setup, because it is limited to a single local node, in comparison to the more mature ways (Tanka and Helm).

I guess what could work fine:

  • Tanka and Helm as production setups
  • docker-compose as a dev setup for quickly trying it out locally
  • running the binaries as a last resort if the above won't work

@rfratto
Copy link
Member

rfratto commented Jan 13, 2020

Personally, I would drop the docker bit ... running Loki using docker cannot be recommended, as it is not a very persistent solution ... the docker command only really works well for short lived containers.

After all, not even docker-compose can be considered a production ready setup, because it is limited to a single local node, in comparison to the more mature ways (Tanka and Helm).

My last company ran all their production containers off of a docker-compose file :)

I get your point, though. I do see value in this in general, if only for documenting how to do it for future contributors or for quickly trying out Loki for evaluation purposes.

We should add a disclaimer to the top of the file to note that we don't recommend using pure Docker or docker-compose in production.

Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

ping @rfratto

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just a few more comments.

I double checked that Docker refers to Docker Compose without the hyphen, this seems to be true.

docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/README.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
docs/installation/docker.md Outdated Show resolved Hide resolved
Signed-off-by: Xiang Dai <764524258@qq.com>
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rfratto rfratto merged commit 43ef52e into grafana:master Jan 16, 2020
@daixiang0 daixiang0 deleted the update-install-doc branch January 17, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Docker installation instructions
4 participants