Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update google.golang.org/protobuf to v1.33.0 #12276

Merged
merged 4 commits into from Mar 20, 2024
Merged

fix: update google.golang.org/protobuf to v1.33.0 #12276

merged 4 commits into from Mar 20, 2024

Conversation

MichelHollands
Copy link
Contributor

What this PR does / why we need it:

CVE-2024-24786 requires an update of the google.golang.org/protobuf module to v1.33.0 .

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@MichelHollands
fix: update google.golang.org/protobuf to v1.33.0
6e616b8 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands requested a review from a team as a code owner March 20, 2024 16:31
trevorwhitney
trevorwhitney approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed make scan-vulnerabilities returns 0 outstanding vulns

@MichelHollands MichelHollands merged commit 3c05724 into release-2.8.x Mar 20, 2024
7 checks passed
@MichelHollands MichelHollands deleted the update_protobuf_in_2.8.x branch March 20, 2024 17:32
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 22, 2024
Merged
@MichelHollands MichelHollands mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorwhitney trevorwhitney trevorwhitney approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichelHollands @trevorwhitney