fix(blooms): logql shard embeds tsdb #12396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
changed the title
owen-d
force-pushed
the
blooms/logql-shard-embeds-tsdb
branch
from
738ae66
to
b31c2c9
Compare
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
…embeds-tsdb Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #12394 which introduced a tricky bug. This PR removes the
astmapper.ShardAnnotationentirely from thelogql.Shardimplementation to prevent similar bugs from accidentally happening in the future. TSDB power-of-two shards use bit-prefixes for shard inclusion as opposed to the modulos (bit-suffix) used by the oldastmappervariant I originally added to Cortex and we ported over here. Thus when iterating TSDB indices but using the other shard calculation logic, we'd erroneously exclude data.