Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bring back bloom components to backend target in SSD #12400

Merged
merged 1 commit into from
Mar 29, 2024
Merged

feat: Bring back bloom components to backend target in SSD #12400

merged 1 commit into from
Mar 29, 2024

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Mar 29, 2024 •
edited

What this PR does / why we need it:

This PR brings back (from #12381) the bloom compactor and bloom gateways to the backend target of the SSD mode.
The flags that enable the compactor and the gateways, as well as actual per-tenant filtering are disabled by default so a user of SSD shouldn't actually use blooms unless they manually enabled them. These flags are:

  • bloom-compactor.enabled
  • bloom-gateway.enabled
  • per tenant bloom_gateway_enable_filtering and bloom_compactor_enable_compaction

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title bring back bloom components to backend target in SSD feature: Bring back bloom components to backend target in SSD Mar 29, 2024
@salvacorts salvacorts changed the title feature: Bring back bloom components to backend target in SSD feat: Bring back bloom components to backend target in SSD Mar 29, 2024
chaudum
chaudum approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@salvacorts salvacorts marked this pull request as ready for review March 29, 2024 12:23
@salvacorts salvacorts requested a review from a team as a code owner March 29, 2024 12:23
@salvacorts salvacorts merged commit d972ce0 into main Mar 29, 2024
12 checks passed
@salvacorts salvacorts deleted the salvacorts/bring-back-blooms-ssd branch March 29, 2024 12:23
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@salvacorts @rhnasc
feat: Bring back bloom components to backend target in SSD (grafana#1…
59eac7a 
…2400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salvacorts @chaudum