Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blooms): Remove blocks not matching any series in task #12401

Merged
merged 2 commits into from
Mar 29, 2024
Merged

fix(blooms): Remove blocks not matching any series in task #12401

merged 2 commits into from
Mar 29, 2024

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Mar 29, 2024 •
edited

What this PR does / why we need it:

We were downloading way more blocks than series for a given task. This was suspicious since we should download up to one block per requested series. Turns out there was a bug in the partitionTasks function where we were not filtering out blocks that didn't match any of the series on a given task.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review March 29, 2024 13:30
@salvacorts salvacorts requested a review from a team as a code owner March 29, 2024 13:30
cyriltovena
cyriltovena approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salvacorts salvacorts merged commit cf71ac7 into main Mar 29, 2024
12 checks passed
@salvacorts salvacorts deleted the salvacorts/reduce-fetched-blocks-query branch March 29, 2024 14:43
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@salvacorts @rhnasc
fix(blooms): Remove blocks not matching any series in task (grafana#1…
77d8f1e 
…2401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salvacorts @cyriltovena