Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update examples to use v13 schema, along with related defaults #12402

Merged
merged 4 commits into from
Mar 29, 2024
Merged

chore: Update examples to use v13 schema, along with related defaults #12402

merged 4 commits into from
Mar 29, 2024

Conversation

paul1r
Copy link
Contributor

@paul1r paul1r commented Mar 29, 2024

What this PR does / why we need it:
Bump examples to use current schema (v12->v13)

Which issue(s) this PR fixes:
Relates to: #10266

Special notes for your reviewer:

Checklist

  • [ x] Reviewed the CONTRIBUTING.md guide (required)
  • [ x] Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner March 29, 2024 14:59
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 29, 2024
JStickler
JStickler approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM, thanks for updating the docs!

slim-bean
slim-bean approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paul1r paul1r merged commit b286075 into main Mar 29, 2024
11 checks passed
@paul1r paul1r deleted the paul1r/update_loki_3.0_config_files branch March 29, 2024 18:57
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@paul1r @JStickler @rhnasc
chore: Update examples to use v13 schema, along with related defaults (…
fe42698 
…grafana#12402)

Co-authored-by: J Stickler <julie.stickler@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paul1r @JStickler @slim-bean