chore: remove experimental flags for l2 cache and memcached "addresses" config #12410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
sandeepsukhani
approved these changes
Mar 30, 2024
owen-d
approved these changes
Mar 30, 2024
trevorwhitney
added a commit
that referenced
this pull request
Apr 1, 2024
commit 018856c Author: Callum Styan <callumstyan@gmail.com> Date: Mon Apr 1 06:40:16 2024 -0700 fix: fix span logging based on changes to request types timestamps (#12393) Signed-off-by: Callum Styan <callumstyan@gmail.com> commit 5190dda Author: Shantanu Alshi <shantanu.alshi@grafana.com> Date: Mon Apr 1 18:30:21 2024 +0530 feat(detected_labels): Initial skeleton for the API (#12390) Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com> commit 0b7ff48 Author: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> Date: Mon Apr 1 14:21:50 2024 +0530 chore: delete request processing improvements (#12259) commit a509871 Author: Ed Welch <edward.welch@grafana.com> Date: Sun Mar 31 22:14:21 2024 -0400 chore: remove experimental flags for l2 cache and memcached "addresses" config (#12410) commit 7480468 Author: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com> Date: Sun Mar 31 18:00:53 2024 +0200 fix: (Bug) correct resultType when storing instant query results in cache (#12312) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> commit 246623f Author: Trevor Whitney <trevorjwhitney@gmail.com> Date: Fri Mar 29 17:05:36 2024 -0600 fix(detected_fields): fix issues with frontend integration (#12406) This PRs fixes issues we found when integrating with the frontend * the `/experimental` api made it difficult to interact with using the existing datasource, so move to `v1/detected_fields` * the config flag was considered cumbersome as the only potential negative impact of the endpoint is when it is used, and nothing is currently using it * the use of an enum in the protobuf produced unexpected results in the json, so type was converted to string
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change promotes the idea of an L1/L2 chunks cache to be non-experimental. It still needs docs on how to use it but I want to get the arguments updated to make sure they are updated before 3.0
I also removed "experimental" from the memcached Addresses config, which we have been using for several years now.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR