Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detected_labels): Add pod as a detected label to demo #12422

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

shantanualsi
Copy link
Contributor

What this PR does / why we need it:
Just adds the pod label to the detected labels skeleton #12390 as per suggestion.

@shantanualsi shantanualsi changed the title Add pod as a detected label to demo feat(detected_labels): Add pod as a detected label to demo Apr 1, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shantanualsi shantanualsi marked this pull request as ready for review April 2, 2024 03:19
@shantanualsi shantanualsi requested a review from a team as a code owner April 2, 2024 03:19
@cyriltovena cyriltovena merged commit a331746 into main Apr 2, 2024
10 checks passed
@cyriltovena cyriltovena deleted the add-pod-detected-label branch April 2, 2024 06:45
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants