Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update deprecated angular graph panel in dashboards mixin #12430

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Apr 2, 2024

What this PR does / why we need it:

Our dashboards mixins were using the deprecated angular panels for graphs instead of the new timeseries pnael type.
This PR updates the panels to use the new panel type and fixes some of the functions form grafana builder to apply stacking and units.

before this PR:
image

After this PR the panels no longer show the warning message.
image

Which issue(s) this PR fixes:
Fixes #11494

Special notes for your reviewer:
I manually reviewed all dashboards and panels to check they showed the same data as previous ones with the same styles.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title Update deprecated angular graph panel in dashboards mixin fix: Update deprecated angular graph panel in dashboards mixin Apr 2, 2024
@salvacorts salvacorts marked this pull request as ready for review April 3, 2024 13:48
@salvacorts salvacorts requested a review from a team as a code owner April 3, 2024 13:48
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating this.

@salvacorts salvacorts merged commit 9fe31c1 into main Apr 5, 2024
10 checks passed
@salvacorts salvacorts deleted the salvacorts/upgrade-loki-panels-from-angular branch April 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Loki dashboards are using Graph (old) plugin
2 participants