Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detected labels - get and filter labels from ingesters #12432

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Apr 2, 2024

What this PR does / why we need it:

Gets data from ingesters to fetch labels and filter the ones that are not relevant. As a next step, we need to refine the filtering process which and fetch data from store and indexes.

References #12341

@shantanualsi shantanualsi force-pushed the detected-labels-api-ii branch 3 times, most recently from d063675 to 8925c7b Compare April 3, 2024 04:52
@shantanualsi shantanualsi marked this pull request as ready for review April 3, 2024 05:08
@shantanualsi shantanualsi requested a review from a team as a code owner April 3, 2024 05:08
@shantanualsi
Copy link
Contributor Author

(was rebasing and force-pushing only till the PR was draft)

pkg/querier/querier.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from a quick easy test, lgtm

@cyriltovena cyriltovena merged commit 643f353 into main Apr 3, 2024
10 checks passed
@cyriltovena cyriltovena deleted the detected-labels-api-ii branch April 3, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants