test: Detected Labels tests and minor improvements #12505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanualsi
changed the title
8 tasks
MichelHollands
approved these changes
Apr 11, 2024
trevorwhitney
requested changes
Apr 12, 2024
There was a problem hiding this comment.
I did a review of both these PRs in #12441, and I included a lot of feedback on the tests in that review. Would you mind bringing over the relevant feedback from that review to this PR?
|
@trevorwhitney yes thank you so much! I'll have a look at #12441 and apply the suggestions here as well! |
|
closing this PR as all these changes are merged in #12441 along with PR comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds some missing unit tests to the detected labels endpoint.
Which issue(s) this PR fixes:
NA