chore: remove dead object storage code from the ruler #12825
+0
−357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code path was never used. We always instantiate the storage for the ruler via
NewLegacyRuleStore
. I'm unsure of whether we should be doing a larger refactor here, it looks like this is all leftover from the cortex/mimir fork and revendoring of various code into Loki 3-4 years ago.We can also potentially remove the deprecation note from the docs? It's confusing IMO, since we don't list any of the supposedly "undeprecated"/replacement configs in the docs. CC @dannykopping