fix: Fix nil pointer dereference in bloomstore initialisation #12869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bloom store initialisation updates the shipper configuration which in turn requires the index gateway ring to be initialized in case `-index-gateway.mode` is set to `ring`. Therefore the `BloomStore` module needs to depend on the `IndexGatewayRing` module. Fixes #12270 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
|
Is this going to be released anytime soon? It's been 2 months since the 3.0.0 release and we really want to upgrade to make use of the OTLP integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The bloom store initialisation updates the shipper configuration which in turn requires the index gateway ring to be initialised in case
-index-gateway.modeis set toring.Therefore the
BloomStoremodule needs to depend on theIndexGatewayRingmodule.Which issue(s) this PR fixes:
Fixes #12270
Special notes for the reviewer:
This fix is done against the
release-3.0.xbranch only, because onmain(and therefore future versions), the dependencies and module initialisation changed already, and the bug does not manifest.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR