Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Introduce fixed size memory pool for bloom querier #13039

Merged
merged 18 commits into from
Jun 6, 2024
Merged

perf: Introduce fixed size memory pool for bloom querier #13039

merged 18 commits into from
Jun 6, 2024

Commits on Jun 6, 2024

  1. Pass a buffer allocator to the bloom querier 

    This allows for using different implementations of allocators depending
on the use case
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6088f56 View commit details
    Browse the repository at this point in the history

  2. Free last used page when block querier is closed 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    43acd27 View commit details
    Browse the repository at this point in the history

  3. Add fixed size memory pool allocator 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    388bd82 View commit details
    Browse the repository at this point in the history

  4. Order imports 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    bb57c0f View commit details
    Browse the repository at this point in the history

  5. Fix linter 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5d4a804 View commit details
    Browse the repository at this point in the history

  6. Make slab sizes and capacity for fixed size memory pool configurable 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    38c7ac4 View commit details
    Browse the repository at this point in the history

  7. Move mempool package 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    83d3ee7 View commit details
    Browse the repository at this point in the history

  8. Remove global variable of HeapAllocator 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4a4d149 View commit details
    Browse the repository at this point in the history

  9. Return error instead of panicking 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8146863 View commit details
    Browse the repository at this point in the history

  10. Hide documentation for advanced memory management 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9fbb39a View commit details
    Browse the repository at this point in the history

  11. Fix tests after rebasing 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a122b89 View commit details
    Browse the repository at this point in the history

  12. Add metrics to memory pool 

    ```
loki_mempool_available_buffers_per_slab{slab="..."}
loki_mempool_errors_total{slab="...", reason="..."}
```

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0a5cd51 View commit details
    Browse the repository at this point in the history

  13. fixup! Add metrics to memory pool 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1121d22 View commit details
    Browse the repository at this point in the history

  14. fixup! fixup! Add metrics to memory pool 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f2c925b View commit details
    Browse the repository at this point in the history

  15. fixup! fixup! fixup! Add metrics to memory pool 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    696c4a9 View commit details
    Browse the repository at this point in the history

  16. Fix CSV flag 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    25f4381 View commit details
    Browse the repository at this point in the history

  17. Validate memory management configuration at startup 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d5d867a View commit details
    Browse the repository at this point in the history

  18. Remove skipped test case 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d59ca0b View commit details
    Browse the repository at this point in the history