Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tenant as label name for discarded_samples metrics #1318

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

roidelapluie
Copy link
Contributor

@roidelapluie roidelapluie commented Nov 25, 2019

discarded_samples should use the name labels as the other metrics.

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

discarded_samples should use the name labels as the other metrics.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, LGTM!

@slim-bean slim-bean merged commit 7ccd0ab into grafana:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants