Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [release-2.9.x]: feat: Add backoff to flush op #13275

Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore: [release-2.9.x]: feat: Add backoff to flush op #13275

merged 1 commit into from
Jul 3, 2024
+217 −35

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Jun 20, 2024 •
edited
Loading

What this PR does / why we need it:

Backports #13140 to 2.9.x.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner June 20, 2024 15:18
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jun 20, 2024
@grobinson-grafana grobinson-grafana force-pushed the grobinson/backport-9767807 branch 3 times, most recently from 766290c to c129c4f Compare July 2, 2024 15:59
@grobinson-grafana grobinson-grafana force-pushed the grobinson/backport-9767807 branch 2 times, most recently from 2ac9185 to d5f0198 Compare July 2, 2024 19:35
@github-actions github-actions bot removed the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 2, 2024
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 2, 2024
@grobinson-grafana grobinson-grafana self-assigned this Jul 3, 2024
ashwanthgoli
ashwanthgoli approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grobinson-grafana grobinson-grafana merged commit e64985e into release-2.9.x Jul 3, 2024
11 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/backport-9767807 branch July 3, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

Assignees

@grobinson-grafana grobinson-grafana

Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grobinson-grafana @ashwanthgoli