helm: support adding init containers to the loki pod #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks good to me, would still like to know what @slim-bean thinks :D |
|
yes looks good you just need to rebased and fixes version as they changed in between. |
steven-sheehy
suggested changes
Dec 2, 2019
terjesannum
force-pushed
the
init_containers
branch
2 times, most recently
from
c5e3969
to
bdb73a5
Compare
terjesannum
force-pushed
the
init_containers
branch
from
bdb73a5
to
da88a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for adding init containers the same way you can add extra containers to the loki pod.