Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add debug symbols to loki and promtail debug builds #1342

Merged
merged 1 commit into from
Nov 30, 2019
Merged

Makefile: add debug symbols to loki and promtail debug builds #1342

merged 1 commit into from
Nov 30, 2019

Conversation

whothey
Copy link
Contributor

@whothey whothey commented Nov 30, 2019

What this PR does / why we need it:
removed -s and -w flags of go compiler --ldflags from
GO_LDFLAGS, cleaning up DEBUG_GO_LDFLAGS allowing to
have debug info enabled in debug builds.

Also pushed the removed flags into GO_FLAGS --ldflags to remove debug
info from release binaries.

Which issue(s) this PR fixes:
Fixes #1338

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

removed `-s` and `-w` flags of go compiler `--ldflags` from
GO_LDFLAGS, cleaning up DEBUG_GO_LDFLAGS to have debug info removed.

Also pushed the removed flags into GO_FLAGS `--ldflags` to remove debug
info from release binaries.
@claassistantio
Copy link

claassistantio commented Nov 30, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution :D

@sh0rez sh0rez merged commit 005745d into grafana:master Nov 30, 2019
@chaudum chaudum added the type/bug Somehing is not working as expected label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packaging type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug image doesn't have debug symbols.
4 participants