Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm : allow to define custom parsers to use with fluentbit.io/parser annotation #1430

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

olivierboudet
Copy link
Contributor

@olivierboudet olivierboudet commented Dec 16, 2019

What this PR does / why we need it:

This PR allow to customize the configmap when deploying with helm to add some parsers to use the fluentbit.io/parser annotation.

Checklist

  • Documentation added
  • Tests updated

@claassistantio
Copy link

claassistantio commented Dec 16, 2019

CLA assistant check
All committers have signed the CLA.

@cyriltovena
Copy link
Contributor

Thanks you for this, do you mind updating also the https://github.com/grafana/loki/blob/master/production/helm/fluent-bit/README.md with the new possible helm configuration key.

@olivierboudet
Copy link
Contributor Author

Thanks you for this, do you mind updating also the https://github.com/grafana/loki/blob/master/production/helm/fluent-bit/README.md with the new possible helm configuration key.

done

…tion

Signed-off-by: Olivier Boudet <oboudet@gmail.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 0bd4620 into grafana:master Jan 10, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Encode write-dedupe keys as they are created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants