fluent-bit-plugin: re-enable failing JSON marshaller tests; pass error instead of logging and ignoring #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JensErat
force-pushed
the
jsoniter-bug-fixed
branch
from
7a48e73
to
27d2912
Compare
My upstream bugfix to `json-iterator/go` was accepted. This commit updates to the newest upstream release, adds checks for the returned error message and reenables the commented-out JSON marshaller tests. Re-enabling the JSON marshaller tests that should return an error message, I realized `sendMessage` logged and ignored marshalling errors instead of passing them to the caller. Signed-off-by: Jens Erat <email@jenserat.de>
JensErat
force-pushed
the
jsoniter-bug-fixed
branch
from
27d2912
to
cd1fce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fluent-bit-plugin: re-enable JSON marshal tests
My upstream bugfix to
json-iterator/gowas accepted. This commitupdates to the newest upstream release, adds checks for the returned
error message and reenables the commented-out JSON marshaller tests.
fluent-bit-plugin: pass error message
Re-enabling the JSON marshaller tests that should return an error
message, I realized
sendMessagelogged and ignored marshalling errorsinstead of passing them to the caller.
Which issue(s) this PR fixes:
Follow-up to PR #1310.
Special notes for your reviewer:
I do not see a reason for logging and ignoring the error here, probably just a left-over from cleanign up the initial code that did lots of this. One could argue that at least the other lines get shipped with this behavior, but then again other parts of the function already return errors instead of logging also for single-log-message-errors.
Checklist