fluentd-plugin: call gsub for strings only #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Horkyze Can you sign the CLA ? Otherwise I can repush this with my account. |
|
@cyriltovena it is signed now ;) |
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this pull request
Jan 10, 2020
This was ommitted in the previous PR grafana#1475. Unfortunatelly I need a new version to publish the new gem. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
added a commit
that referenced
this pull request
Jan 10, 2020
This was ommitted in the previous PR #1475. Unfortunatelly I need a new version to publish the new gem. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Calling gsub only for String variables.
Previously it was called on any variable type, which may result in error if the type was Integer.
Which issue(s) this PR fixes:
Fixes #1378
Special notes for your reviewer:
Also deleted the additional space in email list, because
rake specwas crying about it.Am not a ruby programmer, so perhaps there is a better way to fix this?