Fileglob parsing fixes #1485
Merged
Fileglob parsing fixes #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments on this? |
cyriltovena
reviewed
Jan 10, 2020
| // Gets current list of files to tail. | ||
| matches, err := doublestar.Glob(path) | ||
| matches, err := doublestar.Glob(t.path) |
There was a problem hiding this comment.
it seems that before we were passing an abs path ? but not anymore ? I was hoping @slim-bean would have more time to review this.
There was a problem hiding this comment.
@cyriltovena, absolute path is is added in for loop below: https://github.com/grafana/loki/pull/1485/files#diff-f449cd9f72b80900843b80037638cbd7R205
Previously code was assuming that only one path will be specified, now it checks if that is absolute path, and if it is not, it replaces each match with absolute path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updated doulbestar module to version 1.2.2 which contains fix for Glob parsing, please see this issue for details: bmatcuk/doublestar#25
Which issue(s) this PR fixes:
Fixes #1314
Special notes for your reviewer:
I've also rewritten how absolute path is set in
filetarget.goas it was not expecting that more than one path can be specified.Checklist