Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonnet: fix common/defaultPorts parameters #1501

Merged
merged 1 commit into from
Jan 13, 2020
Merged

jsonnet: fix common/defaultPorts parameters #1501

merged 1 commit into from
Jan 13, 2020

Conversation

anarcher
Copy link
Contributor

What this PR does / why we need it:

In loki/common.libsonnet , defaultPorts parameter order doesn't match with ksonnet.beta.4 containerPorts.

// ksonnet.beta.4
newNamed(containerPort='', name=''):: 
    self.withContainerPort(containerPort).withName(name),

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@claassistantio
Copy link

claassistantio commented Jan 11, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

sh0rez
sh0rez approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It is really annoying that the versions of the lib are not interchangeable.

Could you please sign the CLA?

@anarcher
Copy link
Contributor Author

@sh0rez Yes, I signed CLA. :-)

@sh0rez sh0rez merged commit 073258c into grafana:master Jan 13, 2020
@chaudum chaudum added the type/bug Somehing is not working as expected label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0rez sh0rez sh0rez approved these changes

Assignees
No one assigned
Labels
component/packaging size/XS type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anarcher @claassistantio @sh0rez @chaudum