querier: fix panic in tailer when max tail duration exceeds #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
To use GCP service accounts, the scope needs to be provided in the transport options. Currently when trying to use this GCS client via Loki, by mounting the service account `credentials.json` file from a secret and using the `GOOGLE_APPLICATION_CREDENTIALS` environment variable, results in the following error response: ``` err="Post https://www.googleapis.com/upload/storage/v1/b/my-loki-bucket/o?alt=json&prettyPrint=false&projection=full&uploadType=multipart: oauth2: cannot fetch token: 400 Bad Request\nResponse: {\n \"error\": \"invalid_scope\",\n \"error_description\": \"Empty or missing scope not allowed.\"\n}" ``` Signed-off-by: Graham Rhodes <1964861+grahamar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When max tail duration reaches, server closes the connection. A goroutine which keeps checking for connection close message from client does not check for already closed connection. This PR takes care of it.