Promtail: Improve position and size metrics #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM except for the lint failure, anyway |
…he race between these two metrics and the two timers that care about position and size Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean
force-pushed
the
synch-tailing-metrics
branch
from
388df3d
to
2a9b69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update these metrics at the same time to avoid the race between them and the two separate timers which update them currently.
This should help prevent the false positives we see on the file_lagging_alert when log files grow very quickly.
Signed-off-by: Edward Welch edward.welch@grafana.com