Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra command line args for external labels like hostname #1530

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

automatedops
Copy link

What this PR does / why we need it:
Update Promtail Helm chart to allow extra command line args. So we that can pass follow command line argument to Promtail.

-client.external-labels=hostname=$(HOSTNAME)

Which issue(s) this PR related:
#636

@claassistantio
Copy link

claassistantio commented Jan 15, 2020

CLA assistant check
All committers have signed the CLA.

@cyriltovena
Copy link
Contributor

Thank you !

Can you bump loki-stack and promtail chart version please ?

@automatedops
Copy link
Author

Thank you !

Can you bump loki-stack and promtail chart version please ?

Updated.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 765b34d into grafana:master Jan 17, 2020
@automatedops automatedops deleted the feature/promtail-extra-args branch January 17, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants