Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing third-party link #1546

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

mattmendick
Copy link
Contributor

Removing the third-party link. Google is good for finding references or other discussion outside the maintainer's architectural presentations and discussion and directly related projects such as Grafana.

Removing the third-party link. Google is good for finding references or other discussion outside the maintainer's architectural presentations and discussion and directly related projects such as Grafana.
@claassistantio
Copy link

claassistantio commented Jan 17, 2020

CLA assistant check
All committers have signed the CLA.

@rfratto
Copy link
Member

rfratto commented Jan 17, 2020

Can you mention this change in process in the CONTRIBUTING.md file?

@slim-bean
Copy link
Collaborator

I'm not sure how this would really be defined in CONTRIBUTING.md and it's not really mentioned now so i don't think this is necessary.

@rfratto
Copy link
Member

rfratto commented Jan 17, 2020

I was thinking we'd add a section showing that we don't intend to accept third-party links to content about Loki. I understand your point though, I'll leave it up to you.

@slim-bean
Copy link
Collaborator

It's difficult to support something like linking to an external resource, and we have been discussing this in relation to #1263 as well.

While we do not want to discourage the community from creating and promoting tutorials for Loki, it's difficult for us to provide these links on the project pages.

As this is also not typically done in other open source projects like Prometheus and Grafana, for the time being we are going to avoid this as well.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 1deeece into master Jan 17, 2020
@cyriltovena cyriltovena deleted the architectural-further-reading branch January 17, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants