helm: Allow setting 'loadBalancerSourceRanges' for the loki service #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
there some conflitcs if you could take a look |
|
No problem. Just did a rebase and re-bumped the versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows setting the
service.loadBalancerSourceRangesHelm value which then in turn sets thespec.loadBalancerSourceRangesfor the loki service. This is useful in situations where someone wants to set theservice.typeto LoadBalancer and restrict the source networks that can access the service.Which issue(s) this PR fixes:
No issues created for this change.
Special notes for your reviewer:
I bumped the Helm Chart versions but I noticed there are other open PR's that also bumped. Let me know if I need to bump again.
Checklist