Feature/per tenant splitby #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
force-pushed
the
feature/per-tenant-splitby
branch
from
4fc287b
to
c069a2b
Compare
owen-d
force-pushed
the
feature/per-tenant-splitby
branch
from
c069a2b
to
aaef6f6
Compare
cyriltovena
reviewed
Jan 24, 2020
owen-d
force-pushed
the
feature/per-tenant-splitby
branch
from
928d7a4
to
61ff42c
Compare
owen-d
commented
Jan 30, 2020
pkg/querier/queryrange/cache.go
Outdated
| "github.com/cortexproject/cortex/pkg/querier/queryrange" | ||
| ) | ||
|
|
||
| type CacheKeyLimits interface { |
There was a problem hiding this comment.
@cyriltovena Do you think it's excessive to have custom interfaces for this? Should I just inline a cacheKeyLimits{limits} when constructing the cache middleware?
owen-d
force-pushed
the
feature/per-tenant-splitby
branch
from
85662d9
to
f982866
Compare
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
+ Coverage 60.78% 60.97% +0.18%
==========================================
Files 107 108 +1
Lines 8073 8143 +70
==========================================
+ Hits 4907 4965 +58
- Misses 2782 2788 +6
- Partials 384 390 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
querier.split-queries-by-intervalto be specified in overrides files viasplit_queries_by_interval. Previously this was a component wide config. It enables serving tenants of different throughputs.closes #1556