Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds span metadata for split queries #1567

Merged
merged 2 commits into from
Jan 23, 2020
Merged

adds span metadata for split queries #1567

merged 2 commits into from
Jan 23, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 22, 2020

This PR adds a bit of instrumentation around the frontend interval splitting, namely:

  • adds a field to the current span detailing the number of splits
  • each split is now given it's own span with metadata like start & end times. This is very helpful when debugging so we don't have to pull parameters out of URIs and then calculate the timestamps from our numerical timestamps.

cyriltovena
cyriltovena approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit bde0389 into grafana:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owen-d @cyriltovena