Add sleep to canary reconnect on error #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cceeds but there is an error receiving the stream. Signed-off-by: Edward Welch <edward.welch@grafana.com>
rfratto
reviewed
Jan 24, 2020
| fmt.Fprintf(r.w, "error reading websocket, will retry in 10 seconds: %s\n", err) | ||
| // Even though we sleep between connection retries, we found it's possible to DOS Loki if the connection | ||
| // succeeds but some other error is returned, so also sleep here before retrying. | ||
| <-time.After(10 * time.Second) |
mattmendick
approved these changes
Jan 24, 2020
| @@ -207,7 +210,7 @@ func (r *Reader) closeAndReconnect() { | |||
| c, _, err := websocket.DefaultDialer.Dial(u.String(), r.header) | |||
| if err != nil { | |||
| fmt.Fprintf(r.w, "failed to connect to %s with err %s\n", u.String(), err) | |||
There was a problem hiding this comment.
As you did above, perhaps you want to add how many seconds it will sleep for in the log message?
owen-d
approved these changes
Jan 24, 2020
rfratto
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously limited retries on websocket connections when the connection failed, however if the connection succeded but another error was returned we would close and reopen the websocket immediately.
This kills the Loki
Signed-off-by: Edward Welch edward.welch@grafana.com