Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Recommend using the latest schema version (v11) #1608

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

PabloCastellano
Copy link
Contributor

@PabloCastellano PabloCastellano commented Jan 29, 2020

What this PR does / why we need it:

According to the architecture docs, latest schema version is v10 v11. However the documentation mentions only v9 in the examples.

This PR updates the docs and default values accordingly.

Checklist

  • Documentation added
  • Tests updated

@claassistantio
Copy link

claassistantio commented Jan 29, 2020

CLA assistant check
All committers have signed the CLA.

@slim-bean
Copy link
Collaborator

Hey @PabloCastellano thank you for your PR.

The current schema for Loki is actually v11, however we have held off on updating the helm chart because it will break current users, when rolling out a new schema you need to add a new entry to the list of schemas with a future dated start date.

We think it might be possible to do this dynamically however haven't had a chance to figure this out yet. Basically anyone who is doing a new install would want v11 with a date prior to today, anyone doing an upgrade would need a new schema entry with v11 future dated for at least tomorrow.

@PabloCastellano
Copy link
Contributor Author

PabloCastellano commented Jan 29, 2020

Hi @slim-bean, is it OK if I change the PR then to mention v11 and remove the changes related to the helm chart?

Edit: done already

@PabloCastellano PabloCastellano changed the title Documentation: Recommend using the latest schema version (v10) Documentation: Recommend using the latest schema version (v11) Jan 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #1608 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1608   +/-   ##
=======================================
  Coverage   60.69%   60.69%           
=======================================
  Files         107      107           
  Lines        8075     8075           
=======================================
  Hits         4901     4901           
  Misses       2787     2787           
  Partials      387      387

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 94dd756 into grafana:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants